Issue #962, Test Case CG6

[VanishedAIR]

Description

Finished writing code for test case CG6 in the file src\server\test\web\readingsCompareGroupQuantity.js, allowing test case CG6 to successfully run.

Done as part of participating in a CTI program to allow developers to get some beginner-friendly open-source experience.

Worked with Regina Huang and Andre Dargani as part of CTI.

Team members:
@VanishedAIR
@laurarian
@madargani

Partly addresses issue #962

Type of change

• Note merging this changes the database configuration.
• This change requires a documentation update

Checklist

• I have followed the OED pull request ideas
• I have removed text in ( ) from the issue request
• You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

No additional issues as known.

[huss]

Thanks to @VanishedAIR, @laurarian & @madargani for this contribution to OED. The OED records do not indicate that @laurarian has signed the CLA. If this is correct, please use the link in the Description Checklist to do this so the pull request can be reviewed. If you think this is incorrect then please let me know.

[RongHuang14]

Hi, I have signed the CLA now Best, Rong 获取 Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ 发件人: Steven Huss-Lederman ***@***.***> 发送时间: Tuesday, December 17, 2024 8:48:32 AM 收件人: OpenEnergyDashboard/OED ***@***.***> 抄送: Rong Huang ***@***.***>; Mention ***@***.***> 主题: Re: [OpenEnergyDashboard/OED] Issue #962, Test Case CG6 (PR #1412) Thanks to @VanishedAIR<https://github.com/VanishedAIR>, @laurarian<https://github.com/laurarian> & @madargani<https://github.com/madargani> for this contribution to OED. The OED records do not indicate that @laurarian<https://github.com/laurarian> has signed the CLA. If this is correct, please use the link in the Description Checklist to do this so the pull request can be reviewed. If you think this is incorrect then please let me know. ― Reply to this email directly, view it on GitHub<#1412 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASWTAM45HSOQIJUQU3WJA6D2GATTBAVCNFSM6AAAAABTVIE2JKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYGUYTAMBTGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[VanishedAIR]

@huss I believe she just submitted the agreement right now, could you confirm you can see it on your end? Thanks!

[huss]

Thanks to @VanishedAIR, @laurarian & @madargani for their first contribution to OED. Testing found it works as desired. I made two small comments to address. Also, the files docker-compose.yml, package.json and package-lock.json are modified. Normally these would not be altered by adding a new test. Unless you have a reason for the change then these should be undone. I note that there is a new compile/build error that I'm hoping relates to this but I'll look again after the changes are made. Please let me know if you need anything.

[VanishedAIR]

Would it be fine if for the docker-compose.yml, package.json and package-lock.json files I reverted back to the code that is present in the current OED files, because I think they changed when I pulled in some changes.

[huss]

Would it be fine if for the docker-compose.yml, package.json and package-lock.json files I reverted back to the code that is present in the current OED files, because I think they changed when I pulled in some changes.

@VanishedAIR Yes, that should be fine. I think the docker file was changed to allowed access to the Postgres DB. Why the others changed is unclear to me at this time.

[VanishedAIR]

I copy and pasted from the current OED files, and commented the port back to its previous state, and updated the CG6 description. Let me know if anything else needs changes!

[huss]

I am leaving a comment that I realized that the copy/paste that I said was okay changed the git history to show some previous changes in package.json as ones from this PR. I tried to fix but my git ability did not easily make it happen so I am letting it go. It also added some blank lines at the end of a few files. Overall, this is not too important but it will cause developers to have to do an npm install (happens automatically) after they pull this PR.

[huss]

Thanks for updating the code and sorry it took me a few days to get back to this. Review and testing found it works as desired. Congratulations to @VanishedAIR, @laurarian & @madargani on your first accepted contribution to OED.