Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented test case C4 #1414

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

EthanV431
Copy link
Contributor

@EthanV431 EthanV431 commented Dec 18, 2024

Description

Added test C5

Contributors
Ethan Villarosa - EthanV431
Tan Hyunh - thuynh-9084
Anvi - anviik

Partially Addresses #962

(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

(Describe any issues that remain or work that should still be done.)

@huss
Copy link
Member

huss commented Dec 23, 2024

@EthanV431 Thanks for your contribution to OED. I do not see that you have signed the CLA (see link in description) but it is checked. Can you please sign or let me know that the OED records are wrong. Also, did you do this work alone or with a team? If there are others then they also need to sign the CLA. It can be reviewed after the CLA is signed. I'm sorry for the delay in posting this.

@EthanV431 EthanV431 changed the title Implemented test case C4 Implemented test case C4; Issue 962 Dec 30, 2024
@EthanV431 EthanV431 changed the title Implemented test case C4; Issue 962 Implemented test case C4 Dec 30, 2024
@EthanV431
Copy link
Contributor Author

Hello, I worked on this together with Tan Hyunh and Anvi. I signed my CLA, not sure about the others.

@huss
Copy link
Member

huss commented Dec 31, 2024

Hello, I worked on this together with Tan Hyunh and Anvi. I signed my CLA, not sure about the others.

I see the CLA signed by @EthanV431 & @thuynh-9084. I do not see it for @anviik. Could Anvi sign the CLA or let me know if the OED records are off. Thanks.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @EthanV431, @thuynh-9084 & @anviik for your first contribution to OED. Reveiw and testing found it works as desired. Congratulations on your first accepted contribution to OED.

@huss huss merged commit 17d8af6 into OpenEnergyDashboard:development Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants