Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test for BG13 #1421

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

shaikhibrahim2000
Copy link
Contributor

@shaikhibrahim2000 shaikhibrahim2000 commented Feb 4, 2025

Description

This PR adds BG13, ensuring that kWh readings are correctly converted to metric tons of CO₂ (MTon CO₂) within meterDatakWhGroups. The test validates:

  • 1-day bars for 15 + 20-minute reading intervals.
  • Correct application of the 7.09e-4 conversion factor (kWh → MTon CO₂).
  • Proper handling of unbounded start/end times (-inf to +inf).
  • Support for relevant unit conversions (u2, u10, u11, u12) and chained transformations (c11, c12, c13).

This update improves OED’s metric ton CO₂ calculations and ensures consistency with Electric_Utility-based unit conversions.

Partly addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

No known limitations.

@huss
Copy link
Member

huss commented Feb 5, 2025

@shaikhibrahim2000 In the description, the checkbox for the CLA is checked but our records do not indicate you signed the CLA. Let us know if you think that is wrong or please do this via the link in that item above.

@shaikhibrahim2000
Copy link
Contributor Author

@shaikhibrahim2000 In the description, the checkbox for the CLA is checked but our records do not indicate you signed the CLA. Let us know if you think that is wrong or please do this via the link in that item above.

@huss I have signed the CLA.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @shaikhibrahim2000 for their first contribution to OED. Testing and review found the test case works as expected. I have made a couple of small comments on style to address.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @shaikhibrahim2000 on the quick changes. Everything looks good. Congratulations on your first accepted work for OED.

@huss huss merged commit 360b24a into OpenEnergyDashboard:development Feb 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants