Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #962 - Added Test for C12 #1426

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

kundyzs
Copy link
Contributor

@kundyzs kundyzs commented Feb 16, 2025

Description

This PR adds C12, ensuring that kWh readings are correctly converted to kg of CO₂ (kg CO₂). The test validates:

1-day bars for 15 minute reading intervals.
Correct application of the 0.709 conversion factor (kWh → kg CO₂).
Support for relevant unit conversions (u2, u10, u12) and chained transformations (c11, c12).
This update improves OED’s kg CO₂ calculations and ensures consistency with Electric_Utility-based unit conversions.

Contributors:
Kundyz Serzhankyzy - kundyzs
Kevin Jijon - kevJ711
Ye Chan Lin - yechanlin

Partly Addresses #962

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

No known limitations.

kundyzs and others added 4 commits February 12, 2025 13:06
@kundyzs kundyzs changed the title Added Test for C12 Issue #962 - Added Test for C12 Feb 16, 2025
@Chocopepero
Copy link
Contributor

Thanks to @kundyzs, @kevJ711, & @yechanlin for working on this issue. Everything looks good. Just need a final look from @huss and it's good to merge.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @kundyzs, @kevJ711 & @yechanlin for their first contribution to OED. The review by @Chocopepero was fine and taken for approval. Everything looks good. Congratulations on your first accepted work for OED.

@huss huss merged commit 24239e9 into OpenEnergyDashboard:development Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants