C9 test development #1432
Merged
C9 test development #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sophia Alexander <sophiagrace23@g.ucla.edu> Co-authored-by: Aaron Lui <aaronluii15@gmail.com>
update branch
Co-authored-by: Sophia Alexander <sophiagrace23@g.ucla.edu> Co-authored-by: Aaron Lui <aaronluii15@gmail.com>
|
Congrats to @Phinhas214, @aaronlui415, and @shesophast on submitting your first Pull Request! All students have signed the CLA. The test case looks good. Just need a final approval from @huss and it's good to merge. |
I accidentally forgot to use the reversed conversion in the design doc. This fixes the test case to do that. This is not the doing of the developers.
|
I made a mistake in the design document and did not reverse the conversion (used c2 instead of c6). I realized this during my review of this PR. I have pushed a commit to fix this since it was my fault. The original work was fine and correctly implemented what was then in the design document. |
huss
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
@Chocopepero review is taken as approving. Everything looks good. Congratulations to @Phinhas214, @aaronlui415 & @shesophast on their first accepted contribution to OED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a test case C9 for the conversion procedure (from Fahrenheit to Widget). @Phinhas214, @aaronlui415, and @shesophast were working on this as new developers.
Partially addresses #962
Type of change
Checklist
Limitations
Only addresses test case C9.