Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
s0l0ist committed Oct 2, 2024
1 parent a7789b6 commit 91654d8
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
19 changes: 18 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,24 @@

Feat:

- Add support for python 3.12
- Add support for Python 3.12

Fix:

- There was a bug in the pybind11 bindings involving incorrect usage for
releasing the GIL lock which led to a segfault when using Python 3.12.
Previous versions remain unaffected.
- Pin the python `protobuf` version to match
[`rules_proto_grpc_python`](https://github.com/rules-proto-grpc/rules_proto_grpc/blob/master/modules/python/requirements.in#L3)
to remove runtime warnings.

Chore:

- Removed `macos-12` from the `CD` GHA as it was building with an incorrect
wheel name for the given OS. We're only building/publishing wheels for
`macos-14`.
- Removed unused pip deps from `requirements.in` and updated lock files
accordingly.

# Version 2.0.4

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import PSI from '../wasm_node'
import { PSILibrary } from '../implementation/psi'
import PSI from '../wasm_node'

const clientKey = Uint8Array.from([
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21,
Expand Down Expand Up @@ -85,7 +85,7 @@ describe('PSI Integration', () => {
numClientElements / 2
)
// eslint-disable-next-line jest/no-conditional-expect
expect(intersection.length).toBeLessThan(
expect(intersection.length).toBeLessThanOrEqual(
(numClientElements / 2) * 1.1
)
}
Expand Down

0 comments on commit 91654d8

Please sign in to comment.