Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_sheet_load_set_to_16 #532

Merged
merged 1 commit into from
Feb 19, 2025
Merged

default_sheet_load_set_to_16 #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 11 additions & 22 deletions static/js/CommunityPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,11 @@ CommunityPage.propTypes = {


const RecentlyPublished = ({multiPanel, toggleSignUpModal}) => {
// const options = Sefaria.interfaceLang === "hebrew" ? {"lang": "hebrew"} : {};
const options = {};
// options["filtered"] = true;
const pageSize = 10;
const [nSheetsLoaded, setNSheetsLoded] = useState(0); // counting sheets loaded from the API, may be different than sheets displayed
// Start with recent sheets in the cache, if any
const options = {};
const pageSize = 16;
const [nSheetsLoaded, setNSheetsLoaded] = useState(0);
const [recentSheets, setRecentSheets] = useState(collapseSheets(Sefaria.sheets.publicSheets(0, pageSize, options)));

// But also make an API call immeditately to check for updates
useEffect(() => {
loadMore();
}, []);
Expand All @@ -93,32 +89,25 @@ const RecentlyPublished = ({multiPanel, toggleSignUpModal}) => {
const collapsedSheets = collapseSheets(data);
const newSheets = recentSheets ? recentSheets.concat(collapsedSheets) : collapsedSheets;
setRecentSheets(newSheets);
setNSheetsLoded(nSheetsLoaded + pageSize);
setNSheetsLoaded(nSheetsLoaded + pageSize);
if (collapsedSheets.length < until && collapsedSheets.length !== 0) {
loadMore(null, until - collapsedSheets.length);
}
});
};

const recentSheetsContent = !recentSheets ? [<LoadingMessage />] :
recentSheets.map(s => <FeaturedSheet sheet={s} showDate={true} toggleSignUpModal={toggleSignUpModal} />);
const joinTheConversation = (
<div className="navBlock">
<Modules type={"JoinTheConversation"} props={{wide:multiPanel, title: 'side_nav.community.join_conversation'}} />
</div>
);
if (recentSheets) {
recentSheetsContent.splice(6, 0, joinTheConversation);
recentSheetsContent.push(
<a className="button small white loadMore" onClick={loadMore}>
<InterfaceText>{ Sefaria._("common.load_more")}</InterfaceText>
</a>
);
}
recentSheets.slice(0, 16).map(s => <FeaturedSheet sheet={s} showDate={true} toggleSignUpModal={toggleSignUpModal} />);

return (
<div className="recentlyPublished">
<h2><InterfaceText>{ Sefaria._("community.sheets.recently_published")}</InterfaceText></h2>
<NBox content={recentSheetsContent} n={1} />
{recentSheets && recentSheets.length >= 16 && (
<a className="button small white loadMore" onClick={loadMore}>
<InterfaceText>{ Sefaria._("common.load_more")}</InterfaceText>
</a>
)}
</div>
);
};
Expand Down