Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-manchette: refacto how waypoints are displayed #847

Merged
merged 5 commits into from
Feb 6, 2025
Merged

ui-manchette: refacto how waypoints are displayed #847

merged 5 commits into from
Feb 6, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 21, 2025 •
edited
Loading

See commits

To test, you should follow these steps:

  • remove the dist folders in ui-manchette-with-spacetimechart and ui-manchette
  • remove the storybook-static folder in storybook
  • npm run build
  • npm run storybook

@clarani clarani requested a review from a team as a code owner January 21, 2025 10:44
@clarani clarani marked this pull request as draft January 21, 2025 10:45
@clarani clarani force-pushed the cni/refacto-manchette branch from bc3ba44 to 7f59325 Compare February 4, 2025 17:00
@clarani clarani marked this pull request as ready for review February 4, 2025 17:02
@clarani clarani requested review from kmer2016 and Akctarus February 4, 2025 17:03
@clarani clarani self-assigned this Feb 4, 2025
Akctarus
Akctarus reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but when I test it, I get this:

Capture d’écran 2025-02-05 à 11 08 25

I get waypointsToDisplay in my console.log, but they're not displayed (this may be due to a storybook setting)

ui-manchette-with-spacetimechart/src/__tests__/helpers.spec.ts Outdated Show resolved Hide resolved
@clarani
ui-manchette-with-spacetimechart: refacto filterVisibleElements
b6b84ca 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
ui-manchette: remove display props in Waypoint
b9b314e 
The waypoints are filtered in the hook ui-manchette-with-spacetimechart, so the display boolean is not needed anymore.

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
ui-manchette-with-spacetime-chart: remove display props in Waypoint
6b839b4 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
ui-manchette-with-spacetimechart: merge getDisplayedWaypoints and cal…
66d6d9b 
…cWaypointsHeight functions

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
ui-manchette-with-spacetimechart: remove getWaypointsWithPosition
4110fda 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/refacto-manchette branch from 7f59325 to 4110fda Compare February 5, 2025 14:37
@clarani
Copy link
Contributor Author

clarani commented Feb 5, 2025 •
edited
Loading

Hum to test, you should follow these steps:

  • remove the dist folders in ui-manchette-with-spacetimechart and ui-manchette
  • remove the storybook-static folder in storybook
  • npm run build
  • npm run storybook

Can you try again ?

@clarani clarani requested a review from Akctarus February 5, 2025 14:40
Akctarus
Akctarus approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm !

kmer2016
kmer2016 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@clarani clarani added this pull request to the merge queue Feb 6, 2025
Merged via the queue into dev with commit 4110fda Feb 6, 2025
12 checks passed
@clarani clarani deleted the cni/refacto-manchette branch February 6, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees

@clarani clarani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarani @kmer2016 @Akctarus