Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-spacetimechart: zoom rectangle [2/3] #905

Merged
merged 2 commits into from
Mar 11, 2025
Merged

ui-spacetimechart: zoom rectangle [2/3] #905

merged 2 commits into from
Mar 11, 2025

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Feb 17, 2025 •
edited
Loading

space-time zoom-rectangle story

closes OpenRailAssociation/osrd#10827

@anisometropie anisometropie force-pushed the vcs/zoom-rectangle-2 branch 2 times, most recently from 7941890 to b65d392 Compare February 19, 2025 14:56
@anisometropie anisometropie changed the base branch from dev to vcs/zoom-rectangle February 19, 2025 14:58
@anisometropie anisometropie marked this pull request as ready for review February 20, 2025 14:57
@anisometropie anisometropie requested a review from a team as a code owner February 20, 2025 14:57
@anisometropie anisometropie changed the title Vcs/zoom rectangle 2 ui-spacetimechart: zoom rectangle [2/3] Feb 20, 2025
@anisometropie anisometropie force-pushed the vcs/zoom-rectangle branch 3 times, most recently from 0fa1536 to 92cad96 Compare February 21, 2025 09:11
@SharglutDev SharglutDev requested a review from jacomyal February 24, 2025 09:09
@jacomyal
Copy link
Contributor

In both draw-rectangle and rectangle-zoom stories, on Firefox, the space/time chart container is 0x0, until I hover the Storybook left column:
storybook-wtf-noaudio.webm

I think that's why I wrapped the chart itself within a div.absolute.inset-0.

Also, I think the draw-rectangle story should be removed, since it doesn't bring anything that the rectangle-zoom doesn't bring already, and there are also already multiple examples on how to render arbitrary custom layers.

@emersion
Copy link
Member

Side note, the CSS classes for the wrapper divs in stories were recently changed: #858

@anisometropie anisometropie force-pushed the vcs/zoom-rectangle branch 7 times, most recently from a283795 to 49d17be Compare March 5, 2025 20:15
Base automatically changed from vcs/zoom-rectangle to dev March 5, 2025 20:19
@anisometropie anisometropie force-pushed the vcs/zoom-rectangle-2 branch 3 times, most recently from 37a0dc2 to 5594012 Compare March 6, 2025 08:15
@anisometropie
Copy link
Contributor Author

In both draw-rectangle and rectangle-zoom stories, on Firefox, the space/time chart container is 0x0, until I hover the Storybook left column: storybook-wtf-noaudio.webm

I think that's why I wrapped the chart itself within a div.absolute.inset-0.

Also, I think the draw-rectangle story should be removed, since it doesn't bring anything that the rectangle-zoom doesn't bring already, and there are also already multiple examples on how to render arbitrary custom layers.

I removed the draw rectangle story.

display should be fixed !

kmer2016
kmer2016 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

achrafmohye
achrafmohye approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks :)

@anisometropie
ui-spacetimechart: improve data label
3991b91 
data label would disappear if we go too close to the right or bottom border of the canvas. the label now shifts above or left of the mouse to stay visible
@anisometropie anisometropie enabled auto-merge March 11, 2025 15:47
@anisometropie anisometropie added this pull request to the merge queue Mar 11, 2025
Merged via the queue into dev with commit df96f50 Mar 11, 2025
5 of 6 checks passed
@anisometropie anisometropie deleted the vcs/zoom-rectangle-2 branch March 11, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmer2016 kmer2016 kmer2016 approved these changes

@achrafmohye achrafmohye achrafmohye approved these changes

@jacomyal jacomyal Awaiting requested review from jacomyal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Storybook] zoom on chart using rectangle
5 participants
@anisometropie @jacomyal @emersion @kmer2016 @achrafmohye