Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-charts: reorganize manchette folder #961

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 6, 2025

No description provided.

@clarani clarani self-assigned this Mar 6, 2025
@clarani clarani force-pushed the cni/reorganize-manchette-folder branch 3 times, most recently from 3799a52 to 0f3e3c1 Compare March 7, 2025 11:15
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/reorganize-manchette-folder branch from 0f3e3c1 to ea49968 Compare March 7, 2025 13:21
@clarani clarani requested review from Math-R, Akctarus and theocrsb March 7, 2025 13:27
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

@clarani clarani marked this pull request as ready for review March 7, 2025 14:12
@clarani clarani requested a review from a team as a code owner March 7, 2025 14:12
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM
Thanks for sorting it out, it's more understandable like this

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@Math-R Math-R added this pull request to the merge queue Mar 10, 2025
Merged via the queue into dev with commit 81ca556 Mar 10, 2025
6 checks passed
@Math-R Math-R deleted the cni/reorganize-manchette-folder branch March 10, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants