Skip to content

Commit

Permalink
Fix: R2 doesn't support CRC32 validation yet, while "aws s3" demands it
Browse files Browse the repository at this point in the history
AWS CLI decided to enable for everyone strict validation that the
CRC32 is correct on uploading of files. But R2 doesn't support this
yet, resulting in errors.

For now, work around this problem by disabling this validation.
  • Loading branch information
TrueBrain committed Jan 25, 2025
1 parent cd155d0 commit 92566a9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/update-cdn.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ jobs:
--bucket-id ${{ secrets.CDN_R2_BUCKET }} \
--new-release ${{ inputs.folder || github.event.client_payload.folder }}/${{ inputs.version || github.event.client_payload.version }}
aws s3 cp \
# Disable CRC validation, as currently Cloudflare R2 doesn't support this yet.
# See https://www.cloudflarestatus.com/incidents/t5nrjmpxc1cj for more information.
AWS_REQUEST_CHECKSUM_CALCULATION=WHEN_REQUIRED AWS_RESPONSE_CHECKSUM_VALIDATION=WHEN_REQUIRED aws s3 cp \
--recursive \
--endpoint-url ${{ secrets.CDN_R2_ENDPOINT }} \
--only-show-errors \
Expand Down

0 comments on commit 92566a9

Please sign in to comment.