Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logographic detection #2056

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented Mar 2, 2025

  • Trim up some of the data a bit who don't know how to use SEO properly. i.e. possible spamming/poisoning
  • Bug fix using incorrect identifier.

Post #2048

NOTE(s):

  • I tried for HOURS to get these settings into settings.json (hence why the require is left in one file) however RegExp just wouldn't have it no matter what I tried. Existing scripts worked, new scripts did not. If anyone has an idea PRs are welcome to move its location to settings.json.
  • DB migration will happen when I get around to it as this is very complicated since script source has to be reread but at least new scripts will have it.

* Trim up some of the data a bit who don't know how to use SEO properly. i.e. possible spamming/poisoning
* Bug fix using incorrect identifier.

Post OpenUserJS#2048

NOTE(s):
* I tried for HOURS to get these settings into settings.json *(hence why the require is left in one file)* however RegExp just wouldn't have it no matter what I tried. Existing scripts worked, new scripts did not. If anyone has an idea PRs are welcome to move its location to settings.json.
* DB migration will happen when I get around to it as this is very complicated since script source has to be reread but at least new scripts will have it.
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Mar 2, 2025
@Martii Martii merged commit 66ef9fd into OpenUserJS:master Mar 2, 2025
@Martii Martii deleted the Issue-2048logographic branch March 2, 2025 00:25
@Martii
Copy link
Member Author

Martii commented Mar 2, 2025

Pending secondary testing failure... production is one commit back while investigating...

Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Mar 2, 2025
* Revert prior fix as it broke things instead of clearing up identifier naming.
* Change also how the horizontal ellipsis shows up.

Post OpenUserJS#2056 OpenUserJS#2048

* We'll try this again.
Martii added a commit that referenced this pull request Mar 2, 2025
* Revert prior fix as it broke things instead of clearing up identifier naming.
* Change also how the horizontal ellipsis shows up.

Post #2056 #2048

* We'll try this again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

1 participant