Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): error creators for absorbance reader closed lid pipetting #17327

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR introduces utility to get a possible collision with absorbance reader module if the lid is not open (closed or indeterminate). It wires up the absorbance reader closed lid error creator in aspirate, dispense, and moveToWell error creators (checks already used in moveLabware)

Closes AUTH-1079

Test Plan and Hands on Testing

  • in an absorbance reader protocol, open lid and move compatible labware to it
  • close lid
  • add a mix or transfer step that access the plate in absorbance reader (either as source or destination labware), and verify that correct error banner shows for absorbance reader closed lid timeline error

Changelog

  • create utility for possible absorbance reader pipette collision
  • wire up in aspirate, dispense, and moveToWell command creators
  • add tests

Review requests

  • see test plan

Risk assessment

low

…d pipetting

This PR introduces utility to get a possible collision with absorbance reader module if the lid is not open (closed or indeterminate). It wires up the absorbance reader closed lid error creator in aspirate, dispense, and moveToWell error creators (checks already used in moveLabware)

Closes AUTH-1079
@ncdiehl11 ncdiehl11 self-assigned this Jan 22, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader January 22, 2025 19:39
@ncdiehl11 ncdiehl11 marked this pull request as ready for review January 22, 2025 19:39
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner January 22, 2025 19:39
@ncdiehl11 ncdiehl11 removed the request for review from a team January 22, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant