Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add new evotips command support to run log #17402

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Jan 31, 2025

Overview

This PR adds support for evotips commands in the run log

Test Plan and Hands on Testing

Look at the Run Preview for a protocol with evotips commands, see that the commands are now properly parsed:
Screenshot 2025-01-31 at 3 58 31 PM

Changelog

  1. Added three new commands to our pipetting command schema
  2. Added strings and parsed these in our command text utils

Review requests

Check that the param and result types are correct

Risk assessment

Low

@smb2268 smb2268 requested review from a team as code owners January 31, 2025 21:06
@smb2268 smb2268 requested review from koji and removed request for a team January 31, 2025 21:06
Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Sarah!

@smb2268 smb2268 merged commit a667e62 into chore_release-8.3.0 Jan 31, 2025
61 of 62 checks passed
@smb2268 smb2268 deleted the app_evotips-command-text branch January 31, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants