Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix HighlightItems logic #17457

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR fixes implementation of HoveredItems. We first check if the hovered item is a labware, and if so, if it is an adapter. If it is an adapter with a module underneath, we highlight the module rather than the adapter. Otherwise, we highlight the labware/adapter itself.

Closes RQA-3951

Test Plan and Hands on Testing

  • import this protocol and add a move step
  • hover around the options for new location and verify that the highlight is correct

Changelog

  • add logic for checking if highlighted item is an adapter on a module
  • implement logic in returns for getLabwareItems and getModuleItems

Review requests

see test plan

Risk assessment

low

This PR fixes implementation of HoveredItems. We first check if the hovered item is a labware, and if so, if it is an adapter. If it is an adapter with a module underneath, we highlight the module rather than the adapter. Otherwise, we highlight the labware/adapter itself.

Closes RQA-3951
@ncdiehl11 ncdiehl11 requested a review from koji February 6, 2025 21:46
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 6, 2025 21:49
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 6, 2025 21:49
@ncdiehl11 ncdiehl11 self-assigned this Feb 6, 2025
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 7e160c1 into chore_release-pd-8.4.0 Feb 6, 2025
24 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-highglightitems branch February 6, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants