Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (abr-testing): Low Volume 96ch Protocols + Full Liquid Set up Protocol #17475

Open
wants to merge 11 commits into
base: edge
Choose a base branch
from

Conversation

rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Feb 7, 2025

Overview

Low Volume 96ch pipette protocol

Test Plan and Hands on Testing

  • tested protocols on robots

Changelog

Added 3 protocols

  • 2 96ch low volume ones at api 2.23
  • corrected some error recording issues with retrieving protocol files
  • created protocol to fill all plates for robots with a 96ch

Review requests

@sfoster1 I have noticed that the robots will have their protocol files saved in different numbered folders with opentrons-robot-server. How can I get this scrip to iterate these folders to find the file that matches the protocol_id?

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner February 7, 2025 21:51
@rclarke0 rclarke0 requested a review from sfoster1 February 7, 2025 21:51
@sfoster1
Copy link
Member

sfoster1 commented Feb 7, 2025

@sfoster1 I have noticed that the robots will have their protocol files saved in different numbered folders with opentrons-robot-server. How can I get this scrip to iterate these folders to find the file that matches the protocol_id?

those are schema IDs; they represent the format that all the data the robot server stores things in. you can parse them all as numbers and use the biggest number (parse them as floats though, because we have like 8.1 in there sometimes).

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.37%. Comparing base (f5cdb6b) to head (91e8de5).
Report is 4 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17475      +/-   ##
==========================================
+ Coverage   26.17%   26.37%   +0.20%     
==========================================
  Files        2835     2835              
  Lines      217682   217701      +19     
  Branches     9276     9822     +546     
==========================================
+ Hits        56971    57427     +456     
+ Misses     160694   160254     -440     
- Partials       17       20       +3     
Flag Coverage Δ
app 2.49% <ø> (-0.93%) ⬇️
components 4.65% <ø> (?)
protocol-designer 18.85% <ø> (ø)
step-generation 4.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 118 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants