Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended XYZ file output for static run and structural optimization #318

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

JianboLin
Copy link
Contributor

We have an option for output of extended-xyz file in run types of MD simulation.
But when we would like to check, save, or even visualize the atomic forces of specific geometry or during the structural optimization, add the same option in run types of static and structural optimization, would be convenient.

At present, from my tests, it works with static, cg, lbfgs, sqnm and also with cell optimization
detail in #305

structural optimization with cell optimization:
cell_sqnm, full_sqnm, cell_cg_run, full_cg_run_single_vector
@JianboLin JianboLin added area: main-source Relating to the src/ directory (main Conquest source code) improves: functionality Adding functionality to code needs: review Some review required: still an issue? Way forward clear? labels Feb 6, 2024
Copy link
Contributor

@davidbowler davidbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a variable XYZfreq (in control.f90) which is used to define how often this file is written out (at present only during MD, in md_misc_module.f90). I wonder whether we should use it here: what do you think?

@JianboLin
Copy link
Contributor Author

Thank you for your comment.
Static calculation or structural optimization (including opt cell ) may not have large number of steps, supposing several hundred steps.
And it may be also okay if we use default XYZfreq=1, in these run types (except static).

@tsuyoshi38
Copy link
Contributor

Thank you for your comment. Static calculation or structural optimization (including opt cell ) may not have large number of steps, supposing several hundred steps.

I understand your point.

And it may be also okay if we use default XYZfreq=1, in these run types (except static).

But, since it might help in some cases, could you do it?

MDfreq for md
1 for other runtype
If copy initial_read_module.f90 from develop branch,
some new changes from other branch will be also appear in this branch.
@JianboLin
Copy link
Contributor Author

JianboLin commented Feb 8, 2024

Yes, updated in the latest commit. By the way, do we also need to control output frequency of xsf file with XSFfreq in these types of run?

@JianboLin
Copy link
Contributor Author

Thank you for your approval.

@JianboLin JianboLin merged commit 1741c4d into develop Feb 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: main-source Relating to the src/ directory (main Conquest source code) improves: functionality Adding functionality to code needs: review Some review required: still an issue? Way forward clear?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants