Extract inner cri calc into separate subroutine #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connoraird
force-pushed
the
346-extract-inner-calc
branch
from
02824e0 to
ddab600
Compare
connoraird
force-pushed
the
346-extract-inner-calc
branch
10 times, most recently
from
0f3327e to
fb1641d
Compare
connoraird
force-pushed
the
346-extract-inner-calc
branch
from
fb1641d to
a8b3685
Compare
connoraird
force-pushed
the
346-extract-inner-calc
branch
3 times, most recently
from
c1e66db to
47bfa7d
Compare
connoraird
force-pushed
the
346-extract-inner-calc
branch
from
47bfa7d to
ec4f1d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the code within the
do nsf2 = 1, jb%nsuploop ofm_kern_exx_criandm_kern_exx_eriis almost identical. Therefore, we should be able to extract this into a subroutine and therefore get the gain of using BLAS and any other optimisation in one place.The current issue is that in
m_ker_exx_erithere is an option tobackup_eris. If true, this contiguously accesses a 1D array viaeris(kpart)%store_eris(count). With the new OpenMP thread implementation we no longer access these elements in this order.