Skip to content

Commit

Permalink
Made indexes inside binary search signed integers
Browse files Browse the repository at this point in the history
  • Loading branch information
br-41n committed Jan 24, 2024
1 parent 0aac2ab commit c2d0435
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions contracts/v2/ShardingTable.sol
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ contract ShardingTableV2 is Named, Versioned, ContractStatus, Initializable {
function _binarySearchForPosition(uint256 hashRingPosition) internal virtual returns (uint72, uint72) {
ShardingTableStorageV2 sts = shardingTableStorage;

uint72 left = 0;
uint72 mid;
uint72 right = sts.nodesCount() - 1;
int72 left;
int72 mid;
int72 right = int72(sts.nodesCount()) - 1;

uint72 prevIdentityId;
uint72 nextIdentityId;
while (left <= right) {
mid = (left + right) / 2;
ShardingTableStructsV2.Node memory currentNode = sts.getNodeByIndex(mid);
ShardingTableStructsV2.Node memory currentNode = sts.getNodeByIndex(uint72(mid));

if (currentNode.hashRingPosition < hashRingPosition) {
prevIdentityId = currentNode.identityId;
Expand Down

0 comments on commit c2d0435

Please sign in to comment.