-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eofs desafio3 to master #1018
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed unction to work with set, custo limit and prime quantity range added, printing one result by line added
Readme created on oot directory
Updates on the function preserving only calculations. Functions variables are now global. Print logic changed to avoid errors.
Readme updated to match new file's name
Update on error handling for constants to include a greater range of user's input scenarios
Sieve of Eratosthenes module created to allow escalability. Primos.py now only contains the function call within the loop.
Calculation module change to be inline with Python PEEP-8
Main module name changed from primos to __main__.py to be inline with Python best practices
Changes made on Redme to better clarify file functionality based on last changes
gitignore created to prevent cache files to be commited
Update on main script
Class PrimeCalc's methods updated to avoid overwriting on main's execution. Main update for proper execution
remove trail space from line 83.
Update on file docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.