Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprint for Ivanti vTM #56

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

nmasdoufi-ol
Copy link
Contributor

@nmasdoufi-ol nmasdoufi-ol commented Sep 3, 2024

Added fingerprint for Ivanti vTM

image

image

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (4f90a9e) to head (6bf4c4e).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files           3        3           
  Lines         610      610           
=======================================
  Hits          590      590           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amine3
amine3 previously requested changes Sep 3, 2024
Copy link
Member

@amine3 amine3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you validate this fingerprint is working? Provide details or add a unit test?

@nmasdoufi-ol
Copy link
Contributor Author

How did you validate this fingerprint is working? Provide details or add a unit test?

Done.

@3asm 3asm dismissed amine3’s stale review September 3, 2024 12:12

Comment fixed.

@3asm 3asm merged commit 3a94b15 into main Sep 3, 2024
5 checks passed
@3asm 3asm deleted the feature/add_fingerprint_ivanti_vtm branch September 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants