Address comments.

src/ostorlab/agent/message/proto/v3/report/vulnerability/vulnerability.proto

@@ -53,8 +53,8 @@ message CallTrace {
 
 message Metadata {
   optional MetadataTypeEnum  type = 1;
-  oneof value {
-    string raw_value = 2;
+  oneof metadata_value {
+    string value = 2;
     CallTrace calltrace = 3;
   }
 }

src/ostorlab/agent/mixins/agent_report_vulnerability_mixin.py

@@ -43,6 +43,7 @@ class Frame:
     package_name: Optional[str] = None
 
     def to_proto_dict(self) -> FrameProtoDictType:
+        """Return a dictionary structured same as the corresponding `Frame` protobuf field of the callTrace message."""
         proto_dict_value: FrameProtoDictType = {"function_name": self.function_name}
         if self.class_name is not None:
             proto_dict_value["class_name"] = self.class_name
@@ -58,6 +59,7 @@ class CallTrace:
     frames: List[Frame] = dataclasses.field(default_factory=lambda: [])
 
     def to_proto_dict(self) -> CallTraceProtoDictType:
+        """Return a dictionary structured same as the corresponding `callTrace` protobuf message."""
         proto_dict_value: CallTraceProtoDictType = {
             "frames": [frame.to_proto_dict() for frame in self.frames]
         }
@@ -77,7 +79,7 @@ def to_proto_dict(self) -> VulnerabilityLocationMetadataProtoDictType:
             "type": self.metadata_type.name
         }
         if isinstance(self.value, str):
-            proto_dict_value["raw_value"] = self.value
+            proto_dict_value["value"] = self.value
         if isinstance(self.value, CallTrace):
             proto_dict_value["calltrace"] = self.value.to_proto_dict()
         return proto_dict_value

tests/agent/mixins/agent_report_vulnerability_mixin_test.py

@@ -218,23 +218,10 @@ def testFrameToProtoDict_whenAllFieldsAreSet_returnsCompleteDict() -> None:
     }
 
 
-def testCallTraceToProtoDict_whenAllFieldsAreSet_returnsCompleteDict() -> None:
+def testCallTraceToProtoDict_whenAllFieldsAreSet_returnsCompleteDict(
+    call_trace: agent_report_vulnerability_mixin.CallTrace,
+) -> None:
     """Test that to_proto_dict returns a complete dictionary when all fields are set."""
-    frame1 = agent_report_vulnerability_mixin.Frame(
-        function_name="test_func1",
-        class_name="TestClass1",
-        package_name="test.package1",
-    )
-    frame2 = agent_report_vulnerability_mixin.Frame(
-        function_name="test_func2",
-        class_name="TestClass2",
-        package_name="test.package2",
-    )
-
-    call_trace = agent_report_vulnerability_mixin.CallTrace(
-        frames=[frame1, frame2],
-    )
-
     proto_dict = call_trace.to_proto_dict()
 
     assert proto_dict == {