Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make asset classes fields dataclass fields #863

Merged
merged 7 commits into from
Feb 17, 2025
+43 −92

Add __post_init__ method to initialize ip version if None

4e3f442
Select commit
Loading
Failed to load commit list.
Merged

Fix: Make asset classes fields dataclass fields #863

Add __post_init__ method to initialize ip version if None
4e3f442
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 17, 2025 in 1s

62.52% (-0.17%) compared to 19a1686

View this Pull Request on Codecov

62.52% (-0.17%) compared to 19a1686

Details

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 62.52%. Comparing base (19a1686) to head (4e3f442).

Files with missing lines Patch % Lines
src/ostorlab/assets/agent.py 0.00% 5 Missing ⚠️
src/ostorlab/assets/api_schema.py 0.00% 4 Missing ⚠️
src/ostorlab/assets/ip.py 33.33% 4 Missing ⚠️
src/ostorlab/assets/android_aab.py 0.00% 3 Missing ⚠️
src/ostorlab/assets/android_apk.py 0.00% 3 Missing ⚠️
src/ostorlab/assets/file.py 0.00% 3 Missing ⚠️
src/ostorlab/assets/ios_ipa.py 0.00% 3 Missing ⚠️
src/ostorlab/assets/ipv4.py 0.00% 3 Missing ⚠️
src/ostorlab/assets/ipv6.py 0.00% 3 Missing ⚠️
src/ostorlab/assets/link.py 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   62.68%   62.52%   -0.17%     
==========================================
  Files         342      342              
  Lines       14551    14540      -11     
==========================================
- Hits         9122     9091      -31     
- Misses       5429     5449      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov