Sort dna dict #870
Closed
Sort dna dict #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2025 10:48
| Returns: | ||
| A sorted dictionary or list. | ||
| """ | ||
| if isinstance(dictionary, dict): |
There was a problem hiding this comment.
Suggested change
| if isinstance(dictionary, dict): | |
| if isinstance(dictionary, dict) is True: |
| """ | ||
| if isinstance(dictionary, dict): | ||
| return {k: _sort_dict(v) for k, v in sorted(dictionary.items())} | ||
| if isinstance(dictionary, list): |
There was a problem hiding this comment.
if isinstance(dictionary, list) is True:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 62.54% 62.57% +0.02%
==========================================
Files 342 342
Lines 14553 14575 +22
==========================================
+ Hits 9102 9120 +18
- Misses 5451 5455 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I've added the logic to sort the DNA dictionary to unify the sorting logic in one place and remove duplicate code, so the agent does not have to handle sorting on their side.