Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use simpler function in {first|last}_run #1530

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Use simpler function in {first|last}_run #1530

merged 6 commits into from
Nov 30, 2023

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Nov 16, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Use an intermediate step instead of rle in first/last run computations

Does this PR introduce a breaking change?

No

Other information:

@coxipi coxipi changed the title Use _cumsum_reset_on_zero instead of rle in {first|last}_run Use simpler function in {first|last}_run Nov 16, 2023
@coveralls
Copy link

Coverage Status

coverage: 89.812%. first build
when pulling 201c8a7 on faster_first_last_run
into d382912 on master.

Zeitsperre
Zeitsperre approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zeitsperre Zeitsperre requested a review from huard November 30, 2023 19:20
@Zeitsperre Zeitsperre added the approved Approved for additional tests label Nov 30, 2023
@coxipi coxipi merged commit 99f63dd into master Nov 30, 2023
7 checks passed
@coxipi coxipi deleted the faster_first_last_run branch November 30, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@huard huard Awaiting requested review from huard

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faster rl.{first|last}_run implementation
3 participants
@coxipi @coveralls @Zeitsperre