Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing types in yaml schema #1600

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Add missing types in yaml schema #1600

merged 6 commits into from
Jan 24, 2024

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Jan 15, 2024 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Allows "str" for indicator parameter "src_freq"
  • Allows "kind : int" for indicator parameter's parameters.

Does this PR introduce a breaking change?

No, it simply validates yaml definition that were supported before.

Other information:

I added a note to the module doc about "kind" and how it is meant to be used in a yaml.

@github-actions github-actions bot added the indicators Climate indices and indicators label Jan 15, 2024
juliettelavoie
juliettelavoie approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the issue, thank you!

@github-actions github-actions bot added the approved Approved for additional tests label Jan 16, 2024
@coveralls
Copy link

coveralls commented Jan 22, 2024 •
edited
Loading

Coverage Status

coverage: 90.299%. remained the same
when pulling 8368412 on fix-yamale-schema
into f28cbbd on master.

@Zeitsperre
Copy link
Collaborator

@aulemahal feel free to merge!

@aulemahal aulemahal merged commit e1148b2 into master Jan 24, 2024
18 checks passed
@aulemahal aulemahal deleted the fix-yamale-schema branch January 24, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

@huard huard Awaiting requested review from huard

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yamale error validating data with schema for xscen conversion
4 participants
@aulemahal @coveralls @Zeitsperre @juliettelavoie