Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calendar.py #1929

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Update calendar.py #1929

merged 2 commits into from
Sep 19, 2024

Conversation

Balinus
Copy link
Contributor

@Balinus Balinus commented Sep 18, 2024

Seems like it should be worded as "biggest" (or a synonym) here and not "smallest"

Pull Request Checklist:

Seems too straightforward as a change.

What kind of change does this PR introduce?

  • Documentation

Does this PR introduce a breaking change?

Nope

Other information:

Seems like it should be "biggest" here
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Merci!

@Zeitsperre Zeitsperre added the approved Approved for additional tests label Sep 19, 2024
@Zeitsperre Zeitsperre merged commit f6ae812 into Ouranosinc:main Sep 19, 2024
28 checks passed
@Zeitsperre
Copy link
Collaborator

Thanks @Balinus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants