Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test to find xclim location via importlib #2028

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Dec 18, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • The TestOfficialYaml test now uses a dynamic method for locating the installed location of xclim.

Does this PR introduce a breaking change?

No.

Other information:

When xclim is installed, there is no guarantee that src will be the top-level folder. This is by design to ensure that we don't write tests that try to navigate the folder-tree of xclim using relative paths from the tests folder. Seeing as this is the only failing test on conda-forge, I think we're doing an OK job.

Commit that bypasses this problem on conda-forge: conda-forge/xclim-feedstock@f1886ee

Signed-off-by: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre added the bug Something isn't working label Dec 18, 2024
@Zeitsperre Zeitsperre requested a review from aulemahal December 18, 2024 16:21
@Zeitsperre Zeitsperre self-assigned this Dec 18, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Jan 8, 2025
@coveralls
Copy link

coveralls commented Jan 8, 2025

Coverage Status

coverage: 89.934% (-0.03%) from 89.962%
when pulling 1456e8b on adjust-yaml-test
into e34df04 on main.

@Zeitsperre Zeitsperre merged commit 9cce44b into main Jan 15, 2025
21 checks passed
@Zeitsperre Zeitsperre deleted the adjust-yaml-test branch January 15, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants