Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests for Windows environments #2057

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jan 23, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Skips an encoding test that is not supported on Windows
  • Allows connection to GitHub for an xarray test dataset required for one test.

Does this PR introduce a breaking change?

No.

Other information:

@baptistehamon if you have a minute, could you verify two things?

  1. Does your development environment include pytest-socket?
  2. Could you run the two affected tests here on your system to verify that they pass?

Thanks so much!

Signed-off-by: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre added the bug Something isn't working label Jan 23, 2025
@Zeitsperre Zeitsperre self-assigned this Jan 23, 2025
@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Jan 23, 2025
@Zeitsperre Zeitsperre requested a review from coxipi January 23, 2025 18:37
@baptistehamon
Copy link

Indeed, pytest-socket wasn't installed in my environment. I ran the pytest both with and without the module.

  • Without the module installed, I had the following error when running the test on your PR:
    =================================== ERRORS ====================================
    _____________ ERROR collecting tests/test_sdba/test_adjustment.py _____________
    'enable_socket' not found in markers configuration option
    =========================== short test summary info ===========================
    ERROR tests/test_sdba/test_adjustment.py - Failed: 'enable_socket' not found in markers configuration option
    !!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
    ============================== 1 error in 9.65s ===============================

  • With the module, I still had the same error/fails on my PR but your PR fixes it !

Thanks!

Signed-off-by: Zeitsperre <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre requested a review from aulemahal January 23, 2025 20:38
@github-actions github-actions bot added the approved Approved for additional tests label Jan 23, 2025
@Zeitsperre Zeitsperre merged commit aebd1ce into main Jan 24, 2025
30 checks passed
@Zeitsperre Zeitsperre deleted the skip-nl-langinfo-test branch January 24, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests bug Something isn't working sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants