Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No interpolation on dayofyear #2068

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

No interpolation on dayofyear #2068

wants to merge 2 commits into from

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Feb 7, 2025 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • During the adjusting part of quantile methods, a interpolation on the grouping dimension is done if the interpolation "interp" is chosen. This should not be the case when `group="time.dayofyear", so this option is now blocked

Does this PR introduce a breaking change?

No? Even if interpolation was applied before, it should have done nothing, just a more complicated algorithm for nothing

Other information:

See the discussion here #2019 (comment)

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Feb 7, 2025
@coxipi coxipi requested a review from aulemahal February 7, 2025 13:20
aulemahal
aulemahal approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! Have you seen a change in performance ?

@github-actions github-actions bot added the approved Approved for additional tests label Feb 7, 2025
@coxipi
Copy link
Contributor Author

coxipi commented Feb 7, 2025

That makes sense! Have you seen a change in performance ?

good question, let me see ... darn, wish I had made that benchmark suite...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coxipi @aulemahal