Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize build #5

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Optimize build #5

merged 4 commits into from
Apr 10, 2024

Conversation

doneill
Copy link
Collaborator

@doneill doneill commented Apr 6, 2024 •
edited
Loading

Summary

Optimize build to migrate from standard typescript to webpack.

Fixes

#6

Proposed changes

  • Move all tests out of src directory
    • Ensure tests are not included in build
  • Build using webpack to dist directory
  • Update Readme

Test

  • Run the following build phases and ensure all pass
    • yarn clean
    • yarn build
      • Confirm build output in dist folder
    • yarn test
    • npm ci

@doneill doneill merged commit fd226d3 into develop Apr 10, 2024
2 checks passed
@doneill doneill mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugohabel hugohabel hugohabel approved these changes

@Alex79373 Alex79373 Alex79373 approved these changes

@leo-ori leo-ori leo-ori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doneill @hugohabel @Alex79373 @leo-ori