Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework source IDs to include all information for citations #200

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

znichollscr
Copy link
Collaborator

@znichollscr znichollscr commented Feb 25, 2025

Description

Checklist

Please confirm that this pull request has done the following:

  • Documentation added (where applicable)
  • Changelog item added to changelog/

@znichollscr
Copy link
Collaborator Author

@jitendra-kumar would this put all the information you desire in the CVs?

@znichollscr znichollscr changed the base branch from main to cmip7-tables February 25, 2025 19:04
@znichollscr
Copy link
Collaborator Author

x-ref #201, which has the full background/discussion behind this in the clearest form I could think of

Base automatically changed from cmip7-tables to main February 26, 2025 08:41
@znichollscr
Copy link
Collaborator Author

@jitendra-kumar I know there has been a lot of activity in this repo. I think this is the key question for #177 now though so if you have any thoughts, please let me know. Thanks!

@jitendra-kumar
Copy link

Yes these changes look great and provides all we need.

@znichollscr
Copy link
Collaborator Author

@durack1 let's just go with this? Rationale: we can figure out how this plugs into the wider CVs as part of #201

@znichollscr znichollscr marked this pull request as ready for review February 26, 2025 16:26
Copy link

No changes to the database between 'main' branch and 939125a

@znichollscr
Copy link
Collaborator Author

Yes these changes look great and provides all we need

Ok cool. Is this the form of source ID that is being envisaged in other projects? (Maybe better to chime in on #201 with any reply)

@durack1
Copy link
Contributor

durack1 commented Feb 26, 2025

Yes, this project is the small volume, and comparatively simple test case, so let's learn by doing..

The CMIPx projects are more complex, far larger author lists, reuse of models/source_id's across institution_id's, more information being captured in the CVs, etc. I think keeping this as simple as is necessary is key, with an attempt of being simple and nimble so we satisfy the minimum requirements for OSTI DOIs and nothing more at this stage

@znichollscr
Copy link
Collaborator Author

Sounds good. Let's see what comes out of #201

@znichollscr znichollscr merged commit a002341 into main Feb 26, 2025
7 checks passed
@znichollscr znichollscr deleted the rework-source-ids branch February 26, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants