[GA] Fix macOS runs #2891
Merged
[GA] Fix macOS runs #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew no longer supports pre-built (binary) packages on macOS 11. Some binary packages remain (for now). This means that packages are built from source instead, which causes a runner timeout to occur when trying to build the Qt and ZMQ packages. A secondary issue came up with the newer Boost 1.83 version supplied by homebrew for all macOS versions that was causing build errors. To work around this, I've re-worked the CI and CMake workflows to not include Qt/ZMQ on macOS 11 runners, and also set a specific Boost version (1.76) that is still binary compatible with macOS 11
Liquid369
approved these changes
Nov 15, 2023
panleone
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew no longer supports pre-built (binary) packages on macOS 11.
Some binary packages remain (for now). This means that packages are
built from source instead, which causes a runner timeout to occur when
trying to build the Qt and ZMQ packages.
A secondary issue came up with the newer Boost 1.83 version supplied by
homebrew for all macOS versions that was causing build errors.
To work around this, I've re-worked the CI and CMake workflows to
not include Qt/ZMQ on macOS 11 runners, and also set a specific Boost
version (1.76) that is still binary compatible with macOS 11.
llvm 13 ships with macos 11 runners natively, but is still not working for our
CMake builds (we previously used Homebrew's
llvm@13package, which isalso no longer available on macos 11 runners in binary format), so I've
dropped down to llvm 12 instead.
Lastly, and as it's own commit, I was consistently running into an assertion
error with the p2p_invalid_messages.py functional test with counting the
number of
mnpingmessages. An increased wait time has cleared up thisissue.