Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint Position and Velocity controllers startup fix #376

Closed

Conversation

goretkin
Copy link

Fixes #374

@goretkin
Copy link
Author

Sorry, I meant to merge into groovy-devel. I don't know how to change it. Perhaps I need to close this PR and open a new one.

I also wanted to show that this fix is what is already done in other controllers, for example: https://github.com/PR2/pr2_controllers/blob/hydro-devel/robot_mechanism_controllers/src/joint_trajectory_action_controller.cpp#L313 They also use the starting function to set the last_time_.

@goretkin
Copy link
Author

@k-okada Hi, what does the question tag mean? Are you interested in maintaining this package?

@k-okada
Copy link
Contributor

k-okada commented Feb 14, 2018

I'm released these package as a part of our Orphaned Maintanair Project. so not so much interested in 'maintaining' this package, sorry for that.

I'm not sure if we should include this PR, so waiting for other users feedback. Also could you please rebase this on kinetic-devel branch?

c.f. PR2/rqt_pr2_dashboard#20 (comment)

Copy link
Member

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test this on the robot,
but the changes make sense and look good to me.

Merging the commits in groovy or hydro doesn't make sense anymore in my opinion. (unless someone asks for it)
I would propose to re-open this request against kinetic (possibly indigo) and commit it there.

@v4hn
Copy link
Member

v4hn commented Aug 10, 2022

Replaced by #404 (error code: merge event not found -.-")

@v4hn v4hn closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants