coderabit suggestions

PalisadoesFoundation · Feb 16, 2025 · 6fdc408 · 6fdc408
1 parent 1909d58
commit 6fdc408
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/src/utilities/testDbConnection.ts b/src/utilities/testDbConnection.ts
@@ -61,8 +61,8 @@ async function checkCountAfterImport(): Promise<boolean> {
 		return allValid;
 	} catch (error) {
 		console.error(`ERROR: ${error}`);
-		return false;
 	}
+	return false;
 }
 
 /**
@@ -81,17 +81,15 @@ async function updateDatabase(): Promise<boolean> {
 
 		const userId = user[0]?.id;
 
-		await db
+		// Update the user and return the updated row
+		const [updatedUser] = await db
 			.update(schema.usersTable)
 			.set({ name: updatedName })
-			.where(sql`id = ${userId}`);
-
-		const updatedUser = await db
-			.select()
-			.from(schema.usersTable)
-			.where(sql`id = ${userId}`);
+			.where(sql`id = ${userId}`)
+			.returning({ name: schema.usersTable.name });
 
-		if (updatedUser[0]?.name !== updatedName) {
+		// Validate update in one step
+		if (!updatedUser || updatedUser.name !== updatedName) {
 			console.error("ERROR: Database update failed!");
 			return false;
 		}