-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Customise prefix for commit messages created by dependabot #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastianczech maybe it would be good to change this from feat
to chore
or ci
. It's not a change to the code, so no need for a new release
@FoSix I added by purpose |
I'd opt to use a different prefix than "fix" - dependency update is not really one. |
I also believe that |
@michalbil please propose other prefix, which we can use. @pimielowski as we talked internally, if we use For repository For other repositories like Personally I preferred option 1 option from PR description (do release with commit containing prefix chore - it can be achieved by changing release rules according to https://github.com/semantic-release/commit-analyzer?tab=readme-ov-file#releaserules), but after consulting this subject with @FoSix , option 2 was selected (change prefix added by dependabot - it can be done by adding prefix to dependabot.yml file according to https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message) |
Description
PR customises commit messages created by
dependabot
while updatinggithub-actions
.Motivation and Context
In #73 title was manually changed in order to trigger release, in #78 there was no change of title and no release was triggered. For future to avoid manual step we can:
chore
- it can be achieved by changing release rules according to https://github.com/semantic-release/commit-analyzer?tab=readme-ov-file#releaserulesdependabot
- it can be done by addingprefix
todependabot.yml
file according to https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-messageIn PR second solution was chosen, because it allows in future to add commits with
chore
prefix, which are not changing anything in code and should not trigger release.By purpose invalid prefix
CHANGEME
is configured in order to put correct one - if there are breaking changes, then new minor version should be created, but if there are no breaking changes, then only patch version is required.How Has This Been Tested?
Code will be tested next time
dependabot
creates PR.If that change will work correctly, later it can be applied for other repositories:
Types of changes
Checklist