Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change units to be an overridable function #54

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change units to be an overridable function #54

wants to merge 4 commits into from
+40 −30

Conversation

jbamlee
Copy link

@jbamlee jbamlee commented May 7, 2024

Background

  • ERC404 only support 1:1 ERC20:ERC721 ratio
  • There is a need for various ratios for the token and NFT

Summary

  • change units from the immutable to overridable function.

@jbamlee jbamlee requested review from 0xacme and caldereth as code owners May 7, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xacme 0xacme Awaiting requested review from 0xacme 0xacme is a code owner

@caldereth caldereth Awaiting requested review from caldereth caldereth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbamlee