Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pat depends #1232

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix pat depends #1232

merged 2 commits into from
Jan 31, 2025

Conversation

thet
Copy link
Member

@thet thet commented Jan 31, 2025

feat(core dom): Add method is_button.

dom.is_button tests, if an element is a button like element.
Button like elements are the following:

button,
button[type=button],
button[type=submit],
input[type=image],
input[type=button],
input[type=reset],
input[type=submit]

fix(pat-depends): Fix infinite loop situations.

Fix some situations where infinite loops were created of unnecessary
function calls were done:

  • Do not en/disable already en/disabled inputs.
  • Do not trigger and pat-depends element if the input is the element
    itself and not a contained sub-input.
  • Do not trigger input events on button-like elements.

thet added 2 commits January 31, 2025 00:05
dom.is_button tests, if an element is a button like element.
Button like elements are the following:

    button,
    button[type=button],
    button[type=submit],
    input[type=image],
    input[type=button],
    input[type=reset],
    input[type=submit]
Fix some situations where infinite loops were created of unnecessary
function calls were done:

- Do not en/disable already en/disabled inputs.
- Do not trigger and pat-depends element if the input is the element
  itself and not a contained sub-input.
- Do not trigger input events on button-like elements.
@thet thet merged commit 8c40b70 into master Jan 31, 2025
1 check passed
@thet thet deleted the fix-pat-depends branch January 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant