Make sure to disable color in cargo output #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for working on this! Indeed, it seems reasonable. Just letting you know that I will make a proper review in a few moments. In the meantime, maybe rebase to sign your commits, please? Cheers, |
|
Thank you for the quick reaction! I have signed the commits. |
|
Thanks a lot for! We would really appreciate it if you released the new crates.io version with this fix. |
|
Yes, planning to do so sometime during this week. |
|
Released as part of v0.4.3. |
PaulDance
added a commit
that referenced
this pull request
Feb 3, 2024
Signed-off-by: Paul Mabileau <paulmabileau@hotmail.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that
cargoproduces no color in its output, otherwise whenCARGO_TERM_COLORenvironment variable is set toalwaysit messes up the version matching, e.g.:I have also added it for
config getsubcommand just in case.Additionally I have taken a liberty to downgrade the MSRV because the previous version (1.70.0) works just fine and the newest rust requirement introduces some problems into our CI.