Create CalAdapt Download Functions for LOCA downscaled CMIP-5

CHANGELOG.md

@@ -11,6 +11,7 @@ For more information about this file see also [Keep a Changelog](http://keepacha
 
 - Documentation of `make` options including addition of `make help` 
 - Add make option to document a single package with `make documentation pathto/package` 
+- Add caladapt_download_loca functions #3445
 
 ### Fixed
 - updated github action to build docker images
@@ -19,7 +20,7 @@ For more information about this file see also [Keep a Changelog](http://keepacha
 
 ### Changed
 
-- Is is now easier to run PEcAn workflows with no active database connection by setting `settings$database$bety$write` to FALSE or missing (#3398, #3419). In this mode you are reponsible for providing the correct paths/ids for all needed files, and run metadata are not written back to the database.
+- It is now easier to run PEcAn workflows with no active database connection by setting `settings$database$bety$write` to FALSE or missing (#3398, #3419). In this mode you are responsible for providing the correct paths/ids for all needed files, and run metadata are not written back to the database.
 - The following components have changed their licensing. With approval of all their contributors, we now provide them under a BSD 3-clause license rather than the previously used NCSA Open Source license. As a reminder, we intend to relicense the entire system and this list will expand as we gather permission from the relevant copyright owners.
     * `apps/api`
     * Shiny apps `dbsync`, `BenchmarkReport`, `Data-Ingest`, `Elicitation`, `ForecastingDashboard`, `global-sensitivity`, `Pecan.depend`, `SDAdashboard`, and `ViewMet`

CONTRIBUTING.md

@@ -95,6 +95,9 @@ Your PR should include:
 - CITATION.cff: if you are making or have made a non-trivial contribution (please ask if unsure; our approach is inclusive), add your name to the author section.
 - NEWS.md: for each package
 - CHANGELOG.md: add changes to [Unreleased] section
+- Tests for any features that should remain working in the future
+- Documentation files generated by `devtools::document()`
+- Updates to documentation if applicable.
 
 
 ### Push your changes up to GitHub

book_source/02_demos_tutorials_workflows/05_developer_workflows/03_coding_practices/01-coding-style.Rmd

@@ -35,6 +35,32 @@ _Do not_ add packages to `Depends`.
 In general, try to avoid adding new dependencies (especially ones that depend on system libraries) unless they are necessary or already widely used in PEcAn (e.g. GDAL, NetCDF, XML, JAGS, `dplyr`).
 For a more thorough and nuanced discussion, see the [package dependencies appendix](#package-dependencies).
 
+#### PEcAn-Specific Function Conventions {#pecan-function-conventions}
+
+PEcAn has established patterns for function naming and parameter ordering to ensure consistency across modules:
+
+- **Function naming**: 
+  - Functions that download data: `download.<source>` (e.g., `download.ameriflux`).
+  - Functions that convert a met data source to PEcAn standard: `met2CF.<source>` (e.g., `met2CF.ameriflux`).
+  - Functions that convert PEcAn standard met data to a model input: `met2model.<model>` (e.g., `met2model.biocro`).
+  - Functions that convert a model output to a standard format should be named `model2netcdf.<model>` (e.g., `model2CF.biocro`).
+
+- **Parameter order**: Follow standard order and naming for function parameters:
+  1. Required parameters without defaults first:
+     - `outfolder`: Directory where output will be saved (no default)
+     - `start_date`: Beginning date for data (no default)
+     - `end_date`: End date for data (no default)
+  2. Spatial information parameters
+       - lat, lon or
+       - sitename / site_id
+       - sf object
+  3. Product-specific parameters
+  4. Optional parameters with defaults
+
+This pattern is consistent with R norms of placing parameters without defaults before those with defaults. 
+These conventions help maintain consistency across PEcAn modules (meteorology, models, SDA constraints, etc.) 
+and enable scalability.
+
 
 # dplyr
 

docker/depends/pecan_deps_from_github.txt

@@ -9,4 +9,5 @@ ropensci/nneo
 ropensci/traits
 SticsRPacks/SticsOnR
 SticsRPacks/SticsRFiles
+ucanr-igis/caladaptr
 VangiElia/GEDI4R

docker/depends/pecan_package_dependencies.csv

@@ -11,6 +11,7 @@
 "BayesianTools","*","modules/rtm","Imports",FALSE
 "BioCro","*","models/biocro","Suggests",FALSE
 "bit64","*","base/db","Suggests",FALSE
+"caladaptr","*","modules/data.atmosphere","Imports",FALSE
 "coda","*","models/maespa","Suggests",FALSE
 "coda","*","models/sipnet","Suggests",FALSE
 "coda","*","modules/assim.sequential","Imports",FALSE

modules/data.atmosphere/DESCRIPTION

@@ -59,6 +59,7 @@ Imports:
     xts,
     zoo
 Suggests:
+    caladaptr,
     doParallel,
     foreach,
     furrr,
@@ -75,6 +76,7 @@ Suggests:
 Remotes:
     github::adokter/suntools,
     github::chuhousen/amerifluxr,
+    github::ucanr-igis/caladaptr,
     github::ropensci/geonames,
     github::ropensci/nneo
 License: BSD_3_clause + file LICENSE

modules/data.atmosphere/NAMESPACE

@@ -1,5 +1,9 @@
 # Generated by roxygen2: do not edit by hand
 
+S3method(extract,local.CMIP5)
+S3method(extract,local.NLDAS)
+S3method(extract,nc)
+S3method(extract,nc.ERA5)
 export(.download.raw.met.module)
 export(.extract.nc.module)
 export(.met2model.module)
@@ -38,6 +42,7 @@ export(download.PalEON)
 export(download.PalEON_ENS)
 export(download.US_WCr)
 export(download.US_Wlef)
+export(download.caladapt.loca)
 export(downscale_ShortWave_to_half_hrly)
 export(downscale_ShortWave_to_hrly)
 export(downscale_repeat_6hr_to_half_hrly)
@@ -48,10 +53,6 @@ export(downscale_spline_to_half_hrly)
 export(downscale_spline_to_hrly)
 export(equation_of_time)
 export(exner)
-export(extract.local.CMIP5)
-export(extract.local.NLDAS)
-export(extract.nc)
-export(extract.nc.ERA5)
 export(gen.subdaily.models)
 export(get.es)
 export(get.lv)

modules/data.atmosphere/NEWS.md

@@ -1,3 +1,9 @@
+# PEcAn.data.atmosphere 1.8.1
+
+## Added 
+
+* `download_caladapt_loca` to download rasters from Cal-Adapt LOCA dataset given a spatial point or polygon object.
+
 # PEcAn.data.atmosphere 1.8.0.9000
 
 ## Fixed