-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the observation preparation functions for North America SDA experiments. #3451
base: develop
Are you sure you want to change the base?
Conversation
} | ||
if (replace | nchar(Sys.getenv("ed_un")) == 0 | nchar(Sys.getenv("ed_un")) == 0) { | ||
Sys.setenv(ed_un = sprintf( | ||
getPass::getPass(msg = "Enter NASA Earthdata Login Username \n (or create an account at urs.earthdata.nasa.gov) :") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new version seems to require that the system is run interactively. Would there be value in retaining the ability to load authentication from the netrc file? Or could there be instructions on how to run the function prior to execution to set the environment variables? What if the execution is remote (e.g., in the cloud or on a HPC node) where there are different environment variables? Is there a security issue with having passwords stored unencrypted as part of the environment variables? Curious what @robkooper thinks.
…updated MODIS LAI prep functions.
…into SDA_observation
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: