test: improve codebase for new tests

phpmd.xml

@@ -33,7 +33,7 @@
 
 	<rule ref="rulesets/naming.xml/ShortVariable">
 		<properties>
-			<property name="exceptions" value="a,b,i" />
+			<property name="exceptions" value="a,b,i,in" />
 		</properties>
 	</rule>
 	<rule ref="rulesets/naming.xml/ShortMethodName">

src/Application.php

@@ -151,11 +151,13 @@ protected function findCommandByName(string $name):Command {
 		throw new InvalidCommandException($name);
 	}
 
+	/** @SuppressWarnings(PHPMD.ExitExpression) */
 	private function exit():void {
 		if(isset($this->exitHandler)) {
 			call_user_func($this->exitHandler, $this->exitCode);
 		}
 		elseif($this->exitCode !== 0) {
+			// phpcs:ignore
 			exit($this->exitCode);
 		}
 	}

src/Argument/ArgumentList.php

@@ -26,7 +26,10 @@ public function getCommandName():string {
 		return $this->argumentList[0]->getValue() ?? "";
 	}
 
-	/** @param string[] $arguments */
+	/**
+	 * @param string[] $arguments
+	 * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+	 */
 	protected function buildArgumentList(array $arguments):void {
 		if(isset($arguments[0])
 		&& $arguments[0][0] !== "-") {

src/Argument/ArgumentValueListNotSetException.php

@@ -3,4 +3,4 @@
 
 use Gt\Cli\CliException;
 
-class ArgumentValueListNotSetException extends CliException {}
+class ArgumentValueListNotSetException extends CliException {}

src/Argument/CommandArgument.php

@@ -6,7 +6,8 @@ public function __construct(string $commandName) {
 		parent::__construct("", $commandName);
 	}
 
+	// phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
 	protected function processRawKey(string $rawKey): string {
 		return "";
 	}
-}
+}

src/Argument/CommandArgumentList.php

@@ -14,4 +14,4 @@ public function __construct(
 		);
 		parent::__construct($script, ...$commandArguments);
 	}
-}
+}

src/Argument/DefaultArgumentValue.php

@@ -6,4 +6,4 @@ public function __construct(?string $default) {
 		parent::__construct("__DEFAULT__");
 		$this->push($default);
 	}
-}
+}

src/Argument/LongOptionArgument.php

@@ -5,4 +5,4 @@ class LongOptionArgument extends Argument {
 	protected function processRawKey(string $rawKey):string {
 		return substr($rawKey, 2);
 	}
-}
+}

src/Argument/NamedArgument.php

@@ -6,6 +6,7 @@ public function __construct(string $value) {
 		parent::__construct("", $value);
 	}
 
+	// phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
 	protected function processRawKey(string $rawKey): string {
 		return "";
 	}

src/Argument/NamedArgumentValue.php

@@ -1,4 +1,4 @@
 <?php
 namespace Gt\Cli\Argument;
 
-class NamedArgumentValue extends ArgumentValue {}
+class NamedArgumentValue extends ArgumentValue {}

src/Argument/NotEnoughArgumentsException.php

@@ -7,4 +7,4 @@ class NotEnoughArgumentsException extends CliException {
 	public function __construct(string $message) {
 		parent::__construct("Not enough arguments passed. $message.");
 	}
-}
+}

src/Argument/ShortOptionArgument.php

@@ -12,4 +12,4 @@ protected function processRawKey(string $rawKey):string {
 
 		return $key;
 	}
-}
+}

src/CliException.php

@@ -4,6 +4,7 @@
 use RuntimeException;
 
 class CliException extends RuntimeException {
+	/** @SuppressWarnings(PHPMD.StaticAccess) */
 	public function __construct(string $message) {
 		$code = ErrorCode::get(get_class($this));
 
@@ -12,4 +13,4 @@ public function __construct(string $message) {
 			$code
 		);
 	}
-}
+}