Update todos

PikminGuts92 · Feb 7, 2025 · 5e8fbc8 · 5e8fbc8
1 parent 67f0ae5
commit 5e8fbc8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/core/grim/src/model/export.rs b/core/grim/src/model/export.rs
@@ -2456,16 +2456,16 @@ impl GltfExporter {
                         extras: Default::default()
                     });
 
-                    let upper_twist = [
+                    // Constraints should be added directly to model in blender instead
+                    /*let upper_twist = [
                         ("bone_L-upperArm.mesh", "bone_L-upperTwist1.mesh"),
                         ("bone_R-upperArm.mesh", "bone_R-upperTwist1.mesh")
                     ]
                         .iter()
                         .find(|(upper_arm, _)| upper_arm.eq(&bone_name))
                         .map(|(_, upper_twist)| upper_twist);
 
-                    // Constraints should be added directly to model in blender instead
-                    /*if let Some(upper_twist_bone) = upper_twist {
+                    if let Some(upper_twist_bone) = upper_twist {
                         // Find node index of upper twist bone
                         let upper_twist_node_idx = node_map.get(*upper_twist_bone).map(|i| *i).unwrap();
 

diff --git a/core/grim/src/model/import.rs b/core/grim/src/model/import.rs
@@ -62,6 +62,7 @@ impl GltfImporter2 {
         // If bones have no anim events, add to "one" clips
 
         // TODO: Compute global matrix of each bone node for use in converting local gltf space to milo space
+        // TODO: Allow char clips for non-bones (i.e. bone_door in gh2)
         // Just get bones for first skin
         let bone_ids = self
             .document
@@ -209,6 +210,7 @@ impl GltfImporter2 {
                 .collect();
 
             let mut clip = CharClipSamples {
+                name: anim_name,
                 one: CharBonesSamples {
                     samples: EncodedSamples::Uncompressed(one_samples),
                     ..Default::default()