Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages/scripts): update to adjust new oras version #442

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

wuhuizuo
Copy link
Contributor

From oras v1.2.0, there's a break change for cli option of sub command discover. Ref: https://github.com/oras-project/oras/releases/tag/v1.2.0

From oras v1.2.0, there's a break change for cli option of sub command `discover`.
Ref: https://github.com/oras-project/oras/releases/tag/v1.2.0

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind September 30, 2024 11:16
Copy link

ti-chi-bot bot commented Sep 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description of the pull request, it seems that the changes are related to updating the oras version to v1.2.0 and adjusting the discover sub-command option accordingly. The diff shows that the change is made in two files where --format option is added to the oras discover command.

There are no potential problems identified in this pull request. However, it is always a good practice to ensure that the new version of oras does not introduce any new bugs or changes that might affect the existing functionality. It would be helpful to test the changes thoroughly before merging the pull request.

As for fixing suggestions, it would be good to add a test case to ensure that the new version of oras works as expected. Additionally, it would be helpful to update the documentation or README file to reflect the new version and any changes made to the code.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 30, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit fb54b3d into main Sep 30, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/bump-cd-util-relase-iamge branch September 30, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant