-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(packages): compatible with centos7 devtoolset build toolchain #513
Conversation
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
for more information, see https://pre-commit.ci
Based on the pull request title and description, it seems that the changes are related to making the build toolchain compatible with CentOS7 devtoolset. The changes include adding a script to source the devtoolset-8 environment if it exists in the The potential problem with this pull request is that it may cause issues with the build process if devtoolset-8 is not installed or if it is installed in a different location. Additionally, it's not clear if this change has been tested on other environments or if it is specific to a particular setup. To address these issues, the following suggestions can be made:
Overall, this pull request is relatively simple, but it's important to ensure that the changes do not cause issues with the build process. |
Based on the PR title and diff, it seems that the changes are related to making the packages compatible with centos7 devtoolset build toolchain. The changes involve adding a check to source the devtoolset-8 environment if it exists before running the build script. There don't seem to be any potential problems with the changes made in this PR. They look like straightforward modifications to make the package compatible with the specified build toolchain. However, it could be helpful to add some context or explanation in the PR description to make it easier for other developers to understand the changes being made. Additionally, it could be helpful to provide some testing information to confirm that the changes made in this PR are working as expected. Suggested improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wuhuizuo wuhuizuo@126.com