Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages): compatible with centos7 devtoolset build toolchain #513

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo wuhuizuo@126.com

Copy link

ti-chi-bot bot commented Dec 21, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to making the build toolchain compatible with CentOS7 devtoolset. The changes include adding a script to source the devtoolset-8 environment if it exists in the packages.yaml.tmpl file.

The potential problem with this pull request is that it may cause issues with the build process if devtoolset-8 is not installed or if it is installed in a different location. Additionally, it's not clear if this change has been tested on other environments or if it is specific to a particular setup.

To address these issues, the following suggestions can be made:

  1. Add a comment in the code explaining the reason for adding the devtoolset-8 script and the expected behavior.
  2. Test the changes on different environments to ensure that it works as expected.
  3. Consider adding a check to ensure that devtoolset-8 is installed before sourcing the environment. If it is not installed, then provide an error message to the user.

Overall, this pull request is relatively simple, but it's important to ensure that the changes do not cause issues with the build process.

@ti-chi-bot ti-chi-bot bot requested a review from purelind December 21, 2024 04:01
Copy link

ti-chi-bot bot commented Dec 21, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and diff, it seems that the changes are related to making the packages compatible with centos7 devtoolset build toolchain. The changes involve adding a check to source the devtoolset-8 environment if it exists before running the build script.

There don't seem to be any potential problems with the changes made in this PR. They look like straightforward modifications to make the package compatible with the specified build toolchain.

However, it could be helpful to add some context or explanation in the PR description to make it easier for other developers to understand the changes being made. Additionally, it could be helpful to provide some testing information to confirm that the changes made in this PR are working as expected.

Suggested improvements:

  • Add some context or explanation in the PR description to make it easier for other developers to understand the changes being made.
  • Provide some testing information to confirm that the changes made in this PR are working as expected.

@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 21, 2024
Copy link
Contributor Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

ti-chi-bot bot commented Dec 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit fda52d1 into main Dec 21, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/build-config branch December 21, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant