Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Symbolic Recursive Integration for Dommaschk #1496

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
be2df79
implement with m>k subsystem
dpanici Dec 19, 2024
5153b41
Merge branch 'master' into dp/domm-fix
dpanici Dec 25, 2024
7dd2dfa
implement symbolic recursive integration for dommschk. works for comp…
dpanici Dec 26, 2024
d6fd793
move lambdify to set_potentials
dpanici Dec 26, 2024
2ff475d
add sympy requirement
dpanici Dec 26, 2024
7b6362c
change implementation to use jax-differentiable potential after integ…
dpanici Dec 27, 2024
eaa02f0
fix error in fitting
dpanici Dec 27, 2024
7a2112d
remove unneeded args, increase output info
dpanici Dec 27, 2024
e325b20
update changelog
dpanici Dec 28, 2024
fa8f5b8
add test
dpanici Dec 28, 2024
ae307f8
adjust docstring
dpanici Dec 28, 2024
d05c612
Merge branch 'master' into dp/domm-fix
dpanici Jan 3, 2025
735194a
remove jit from potential, remove unneeded class initialization at en…
dpanici Jan 5, 2025
9c310f6
Merge branch 'dp/domm-fix' of github.com:PlasmaControl/DESC into dp/d…
dpanici Jan 5, 2025
8b1c62b
optimize performance of Dommaschk potentials
dpanici Jan 5, 2025
0d6ab65
Merge branch 'master' into dp/domm-fix
dpanici Jan 20, 2025
79be462
Merge branch 'master' into dp/domm-fix
dpanici Jan 20, 2025
26a8c35
move sympy import to backend
dpanici Jan 20, 2025
1f31ef3
add proper ignore for flake8 warning
dpanici Jan 20, 2025
56417f7
Merge branch 'master' into dp/domm-fix
dpanici Jan 21, 2025
7522215
move sympy import
dpanici Jan 21, 2025
6c3a4b2
address comments
dpanici Jan 22, 2025
cdca1bd
Merge branch 'master' into dp/domm-fix
dpanici Jan 22, 2025
8d2d691
Merge branch 'master' into dp/domm-fix
dpanici Jan 22, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ New Features
- ``desc.objectives.Omnigenity`` is now vectorized and able to optimize multiple surfaces at the same time. Previously it was required to use a different objective for each surface.
- Adds a new objective ``desc.objectives.MirrorRatio`` for targeting a particular mirror ratio on each flux surface, for either an ``Equilibrium`` or ``OmnigenousField``.
- Adds the output quantities ``wb`` and ``wp`` to ``VMECIO.save``.
- Change implementation of Dommaschk potentials to use recursive algorithm and symbolic integration.
- Changes hessian computation to use chunked ``jacfwd`` and ``jacrev``, allowing ``jac_chunk_size`` to now reduce hessian memory usage as well.

Bug Fixes
Expand Down
1 change: 1 addition & 0 deletions desc/backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import warnings

import numpy as np
import sympy as sp # noqa: F401
dpanici marked this conversation as resolved.
Show resolved Hide resolved
from termcolor import colored

import desc
Expand Down
Loading
Loading