-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0 #23
Conversation
This version has now been on PL-preprod for a week and (afaik) without any bug. If 2 people could review (correctly) the code so we can merge it on master on deploy it as soon as possible on PL. |
#24 should be merge on this branch before merging it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change:
with lock:
to
lock.aquire() lock.release()
??
Another question where is the documentation for the capabilities of the sandbox containers ?
why is the language of the sandbox en_US ?
We actually had to merge #24 to 1.0.0, as i said above, before merging this branch on master.
To avoid over-indentation of the code on big block (I kept
The container limitations are set at production (in
I never bother changing it, should I set it to fr_FR ? |
Le tgz de base est trop grand #2 Seems to have fix this one as a side effect
Sandbox is slow #3 Not really slow anymore
Exception when launching sandbox #18 Fixed by removing name from container
Installation de Java sur la sandbox #19 Both
pl-java
andpl-javac
has been installedNetwork Breakout #20 Container cannot access internet anymore
Environment created by graders should be kept and used #21 Grader now use most recent env
--reload
is now enforced inmanage.py
EnvView.get()
now return every environments with the given IDAdded
EnvView.head()
to check if an environment exists on the sandboxEvery test of PL - master is working on it, but has to be tested on pl-preprod before being merge on master, especially if it survive a night.