Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 #23

Merged
merged 11 commits into from
Feb 19, 2019
Merged

1.0.0 #23

merged 11 commits into from
Feb 19, 2019

Conversation

qcoumes
Copy link
Contributor

@qcoumes qcoumes commented Feb 11, 2019

Every test of PL - master is working on it, but has to be tested on pl-preprod before being merge on master, especially if it survive a night.

@qcoumes
Copy link
Contributor Author

qcoumes commented Feb 18, 2019

This version has now been on PL-preprod for a week and (afaik) without any bug.

If 2 people could review (correctly) the code so we can merge it on master on deploy it as soon as possible on PL.

@Pavell94000 @mciissee @nimdanor

@qcoumes qcoumes requested review from mciissee and nimdanor February 18, 2019 17:55
@qcoumes
Copy link
Contributor Author

qcoumes commented Feb 18, 2019

#24 should be merge on this branch before merging it.

Copy link
Member

@nimdanor nimdanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change:
with lock:
to
lock.aquire() lock.release()
??

Another question where is the documentation for the capabilities of the sandbox containers ?

why is the language of the sandbox en_US ?

@nimdanor nimdanor merged commit 7449b90 into master Feb 19, 2019
@qcoumes
Copy link
Contributor Author

qcoumes commented Feb 19, 2019

We actually had to merge #24 to 1.0.0, as i said above, before merging this branch on master.
So we are now going to merge #24 on 1.0.0 and then merge 1.0.0 to master once more.

Why did you change:
with lock:
to
lock.aquire() lock.release()
??

To avoid over-indentation of the code on big block (I kept with statement for 1/2 lignes statements)

Another question where is the documentation for the capabilities of the sandbox containers ?

The container limitations are set at production (in config.py) and can vary between servers.

why is the language of the sandbox en_US ?

I never bother changing it, should I set it to fr_FR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants