cleaning up

client.go

@@ -18,12 +18,12 @@ type Client struct {
 }
 
 // NewClient creates a new API client
-func NewClient(apiKey string) (*Client, error) {
+func NewClient(apiKey string) *Client {
 	client := &Client{
 		httpClient: &http.Client{},
 		apiBaseURL: fmt.Sprintf("%s/%s", apiEndpoint, apiVersion),
 		apiKey:     apiKey,
 	}
 
-	return client, nil
+	return client
 }

request.go

@@ -15,7 +15,7 @@ type ErrorResponse struct {
 	Validations []Validation `json:"validations"`
 }
 
-// Validation contains the detials of a API field validation error
+// Validation contains the details of a API field validation error
 type Validation struct {
 	Attribute string `json:"attribute"`
 	Message   string `json:"message"`

snitch.go

@@ -79,6 +79,9 @@ func (c *Client) CheckIn(token string) error {
 	}
 	defer resp.Body.Close()
 	body, err := ioutil.ReadAll(resp.Body)
+	if err != nil {
+		return fmt.Errorf("Error reading the API check-in response: %v", err)
+	}
 
 	if resp.StatusCode == http.StatusAccepted {
 		return nil

snitch_test.go

@@ -19,16 +19,11 @@ var updatedSnitch deadmanssnitch.Snitch
 var updatedTags []string
 
 func init() {
-	var err error
-
 	flag.StringVar(&apiKey, "apikey", "", "Dead Man's Snitch API key")
 	flag.IntVar(&wait, "wait", 0, "Number of seconds to sleep before deleting snitch (so it can be manually verified)")
 	flag.Parse()
 
-	dmsClient, err = deadmanssnitch.NewClient(apiKey)
-	if err != nil {
-		panic(err)
-	}
+	dmsClient = deadmanssnitch.NewClient(apiKey)
 
 	rand.Seed(time.Now().UTC().UnixNano())
 	randomTag = RandomString(10)