-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract and move pressio-ops to https://github.com/Pressio/pressio-ops #676
Comments
cwschilly
added a commit
that referenced
this issue
Sep 26, 2024
cwschilly
added a commit
that referenced
this issue
Sep 26, 2024
cwschilly
added a commit
that referenced
this issue
Sep 26, 2024
cwschilly
added a commit
that referenced
this issue
Sep 27, 2024
cwschilly
added a commit
that referenced
this issue
Sep 27, 2024
cwschilly
added a commit
that referenced
this issue
Oct 1, 2024
cwschilly
added a commit
that referenced
this issue
Oct 1, 2024
cwschilly
added a commit
that referenced
this issue
Oct 1, 2024
cwschilly
added a commit
that referenced
this issue
Oct 1, 2024
fnrizzi
added a commit
that referenced
this issue
Oct 14, 2024
…via-using-httpsgithubcompressiopressio-ops #676: evaluate simplifying things with pressio-ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
status quo
Pressio/pressio
(Pressio upper case is the org name) currently contains the following components:mpl, utils, traits, expressions, ops, ode, solvers, rom
new solution/approach to evaluate
Goal: splitting all this into two separate repos:
Pressio/pressio-ops
: would containsmpl, traits, expressions, ops
Pressio/pressio
: would containsode, solvers, rom
Beside a few pros like easier to maintain, separate concerns, one of the main outcomes of this is that all the code in ode, solvers, rom will be generic since it will be written in terms of operations.
constraints to enforce
pressio-ops
should be a required dependency ofpressio:
should figure out the best way to fetch it when using pressio. Since pressio remains for now a header-only, we should just fetch via cmake internally to make things easy.we remove
utils
, and we just move its functionalities where needed: for example,pressio-ops
does NOT need the logger so we put it in the pressio repo onlyfor pressio-ops we need to ensure that when installing things parent directories of headers remain the same as they are now: so everything should be installed so that it can included as
#include <pressio/roms.hpp>
and similar. Obviously, pressio-ops and pressio do not need to be installed in the same place but we should not change the name of the installation toplevel dir for pressio-ops.macros: some PRESSIO_ENABLE_... will inevitably be defined only in
pressio-ops
orpressio.
But we need to make sure these keep the same names and they are used for both.other things that i am missing
how to proceed
we already created https://github.com/Pressio/pressio-ops we extracted the
mpl, traits, expression, ops
so to move forward we need to:develop
The text was updated successfully, but these errors were encountered: