Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract and move pressio-ops to https://github.com/Pressio/pressio-ops #676

Closed
fnrizzi opened this issue Sep 18, 2024 · 0 comments · Fixed by #690
Closed

extract and move pressio-ops to https://github.com/Pressio/pressio-ops #676

fnrizzi opened this issue Sep 18, 2024 · 0 comments · Fixed by #690
Assignees

Comments

@fnrizzi
Copy link
Member

fnrizzi commented Sep 18, 2024

status quo

Pressio/pressio (Pressio upper case is the org name) currently contains the following components:
mpl, utils, traits, expressions, ops, ode, solvers, rom

new solution/approach to evaluate

Goal: splitting all this into two separate repos:

  • Pressio/pressio-ops: would contains mpl, traits, expressions, ops
  • Pressio/pressio : would contains ode, solvers, rom

Beside a few pros like easier to maintain, separate concerns, one of the main outcomes of this is that all the code in ode, solvers, rom will be generic since it will be written in terms of operations.

constraints to enforce

  1. pressio-ops should be a required dependency of pressio: should figure out the best way to fetch it when using pressio. Since pressio remains for now a header-only, we should just fetch via cmake internally to make things easy.

  2. we remove utils, and we just move its functionalities where needed: for example, pressio-ops does NOT need the logger so we put it in the pressio repo only

  3. for pressio-ops we need to ensure that when installing things parent directories of headers remain the same as they are now: so everything should be installed so that it can included as #include <pressio/roms.hpp> and similar. Obviously, pressio-ops and pressio do not need to be installed in the same place but we should not change the name of the installation toplevel dir for pressio-ops.

  4. macros: some PRESSIO_ENABLE_... will inevitably be defined only in pressio-ops or pressio. But we need to make sure these keep the same names and they are used for both.

  5. other things that i am missing

how to proceed

we already created https://github.com/Pressio/pressio-ops we extracted the mpl, traits, expression, ops so to move forward we need to:

  1. create new branch of the Pressio/pressio repo from develop
  2. evaluate how to do the split and use https://github.com/Pressio/pressio-ops
  3. go/no-go: on moving forward to make this split official
@fnrizzi fnrizzi added this to pressio Sep 18, 2024
@fnrizzi fnrizzi moved this to todo in pressio Sep 18, 2024
@cwschilly cwschilly linked a pull request Sep 26, 2024 that will close this issue
cwschilly added a commit that referenced this issue Oct 1, 2024
cwschilly added a commit that referenced this issue Oct 8, 2024
This reverts commit c0b3119.
@fnrizzi fnrizzi changed the title evaluate simplifying things via using https://github.com/Pressio/pressio-ops extract and move pressio-ops to https://github.com/Pressio/pressio-ops Oct 14, 2024
fnrizzi added a commit that referenced this issue Oct 14, 2024
…via-using-httpsgithubcompressiopressio-ops

#676: evaluate simplifying things with pressio-ops
@github-project-automation github-project-automation bot moved this from todo to Done in pressio Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants