Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use vite + vitest #76

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update to use vite + vitest #76

wants to merge 4 commits into from

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Dec 18, 2024

No description provided.

@cbeer cbeer force-pushed the vite branch 8 times, most recently from 3278b66 to c516db9 Compare December 19, 2024 00:09
@cbeer cbeer force-pushed the vite branch 2 times, most recently from 5de79bd to 27aff56 Compare January 7, 2025 18:19
@lutzhelm
Copy link
Contributor

Just one observation at the moment: changing the Mirador version from 4.0.0-alpha.6 to 4.0.0-alpha.7 breaks the plugin translation.

@cbeer
Copy link
Contributor Author

cbeer commented Jan 28, 2025

Thanks. I've updated the components to use the useTranslation hook instead of expecting t to be passed in as a prop.

@cbeer cbeer mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlo-longley marlo-longley marlo-longley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbeer @lutzhelm @marlo-longley